[DoctrineBridge][Routing] Require PSR-11 container instead of Symfony container #21978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me, it should be ok to change even when a protected property is involved: existing code won't break all of a sudden because of the less restrictive type hint. In any doubt, just to it in another PR to have this one merged earlier is this needs to be discussed. |
|
Alright, will do it in separate PR. Also I didn't bother with deprecated classes like ContainerAwareEventDispatcher. |
GuilhemN
suggested changes
Mar 12, 2017
|
@GuilhemN Like this? |
|
Thank you @enumag. |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2017
… instead of Symfony container (enumag) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle][TwigBundle] Require PSR-11 container instead of Symfony container | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | As discussed in #21978 here is the second PR. Commits ------- 857ce7c [FrameworkBundle][TwigBundle] Require PSR-11 container instead of Symfony container
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed classes can easily use PSR-11 container instead of normal symfony container.
I didn't change any classes that have the
$containerproperty as protected (for exampleSymfony\Bundle\FrameworkBundle\Translation\Translator) because I'm unsure whether that would be considered a BC break. Let me know if you want me to change such classes as well.