[DI] Introduce "container.service_locator" tag, replaces ServiceLocatorArgument #22024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2285b to
d097928
Compare
fabpot
reviewed
Mar 17, 2017
| <argument key="session" type="service" id="session" on-invalid="null" /> | ||
| <argument type="service"> | ||
| <service class="Symfony\Component\DependencyInjection\ServiceLocator"> | ||
| <tag name="service_locator" /> |
There was a problem hiding this comment.
Almost all other tags are of the "X.Y" form. Not sure if we need to call it container.service_locator.
There was a problem hiding this comment.
tag renamed to container.service_locator
d097928 to
fb016d6
Compare
fb016d6 to
5d230b5
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2017
…es ServiceLocatorArgument (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Introduce "container.service_locator" tag, replaces ServiceLocatorArgument | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no (master only) | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I first started working on adding this new "container.service_locator" tag, so here it is. It allows defining and dumping service-locator services properly, where it wasn't possible previously (you had to create a DI extension to do so.) Then I realized that this allowed us to entirely drop `ServiceLocatorArgument` and replace it with the more flexible `ServiceClosureArgument`. This makes things simpler overall, see diff stat. Commits ------- 5d230b5 [DI] Introduce "container.service_locator" tag, replaces ServiceLocatorArgument
|
If you always use |
sstok
added a commit
to rollerworks/PasswordStrengthBundle
that referenced
this pull request
Mar 18, 2017
This PR was merged into the 1.5-dev branch. Discussion ---------- Related to symfony/symfony#22024 Let's hope I don't have to fix this again 😅 Commits ------- 2fa6076 Fix tests failure for Symfony 3.3-dev
|
@sstok adding |
sstok
added a commit
to rollerworks/RollerworksSearchBundle
that referenced
this pull request
Mar 19, 2017
This PR was merged into the 2.0-dev branch. Discussion ---------- | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT Symfony 3.3-dev changed the way how ServiceLocators are registered symfony/symfony#22024 Commits ------- e2c028b Fix compatibility for latest Symfony version
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 4, 2017
…guiluz) This PR was merged into the master branch. Discussion ---------- [DI] Add section about service locators Adds documentation for symfony/symfony#21553 and symfony/symfony#22024. Any suggestion will be much appreciated, as usual. Commits ------- fa19770 Fix service locator declaration f5e4942 Rewords 5efacd0 [DI] Add section about Service Locators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first started working on adding this new "container.service_locator" tag, so here it is.
It allows defining and dumping service-locator services properly, where it wasn't possible previously (you had to create a DI extension to do so.)
Then I realized that this allowed us to entirely drop
ServiceLocatorArgumentand replace it with the more flexibleServiceClosureArgument.This makes things simpler overall, see diff stat.