[DI] Remove useless state from ServiceLocator #22029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a8263e to
e0a5eec
Compare
GuilhemN
reviewed
Mar 16, 2017
| @@ -53,13 +52,12 @@ public function get($id) | |||
| throw new ServiceCircularReferenceException($id, array($id, $id)); | |||
There was a problem hiding this comment.
Do we really need to cover this? The ServiceLocator is not passed to the factories so it is very unlikely to happen.
There was a problem hiding this comment.
Why should we remove the safe guard? Symfony is used into the wild, it needs to handle properly any situations. I see no reason to trade a few lines vs a fatal error, however rare it is.
There was a problem hiding this comment.
Ok, just asking, fine for me as is then.
|
👍 Status: Reviewed |
jakzal
reviewed
Mar 17, 2017
| @@ -40,15 +40,20 @@ public function testGet() | |||
| $this->assertSame('baz', $locator->get('bar')); | |||
| } | |||
|
|
|||
| public function testGetDoesNotExecuteTheSameCallableTwice() | |||
| public function testGetDoesNotMemoize() | |||
There was a problem hiding this comment.
Not a typo :)
https://en.wikipedia.org/wiki/Memoization
|
apart from the typo 👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2017
…rekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Remove useless state from ServiceLocator | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no (master only) | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - One less state to manage for the engine, and allows to deal with non-shared services. Commits ------- e0a5eec [DI] Remove useless state from ServiceLocator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One less state to manage for the engine, and allows to deal with non-shared services.