[Yaml] throw meaningful exception for complex mappings #22058
Closed
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Mar 19, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20579 |
| License | MIT |
| Doc PR |
|
In fact, I think we need to deprecate the current behaviour in 3.3 first and merge this one for 4.0 (see #22059 for the deprecation). |
| @@ -144,6 +144,10 @@ public function parse($value, $flags = 0) | |||
| $values['value'] = $matches['value']; | |||
| } | |||
|
|
|||
| if (isset($values['value'][1]) && '?' === $values['value'][0] && ' ' === $values['value'][1]) { | |||
| throw new ParseException('The parser does not support complex mappings.', $this->currentLineNb + 1, $this->currentLine); | |||
There was a problem hiding this comment.
Complex mappings are not supported. ? To match the style of other error messages (e.g. 'Multiple documents are not supported.')
|
Closing here for now. To be reopened when we start the development of 4.0. |
|
For the records: This change is part of #22770. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.