Skip to content

[FrameworkBundle][Validator] Move Validator passes to the component #22081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2017
Merged

[FrameworkBundle][Validator] Move Validator passes to the component #22081

merged 1 commit into from
Mar 22, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 20, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@chalasr chalasr force-pushed the validator-passes branch 4 times, most recently from 99e3fc3 to 173eac3 Compare March 21, 2017 00:19
@chalasr chalasr mentioned this pull request Mar 21, 2017
Closed
11 tasks
@chalasr
Copy link
Member Author

chalasr commented Mar 21, 2017

appveyor failure unrelated

xabbuh
xabbuh reviewed Mar 21, 2017
View reviewed changes
src/Symfony/Component/Validator/DependencyInjection/AddConstraintValidatorsPass.php Outdated
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\DependencyInjection\ServiceLocator;

class AddConstraintValidatorsPass implements CompilerPassInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing author

xabbuh
xabbuh reviewed Mar 21, 2017
View reviewed changes
src/Symfony/Component/Validator/DependencyInjection/AddValidatorInitializersPass.php Outdated
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;

class AddValidatorInitializersPass implements CompilerPassInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@chalasr chalasr force-pushed the validator-passes branch 4 times, most recently from 4f7c4a1 to b1c608f Compare March 22, 2017 15:36
@chalasr
Copy link
Member Author

chalasr commented Mar 22, 2017

rebased

@fabpot
Copy link
Member

fabpot commented Mar 22, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 0b741da into symfony:master Mar 22, 2017
fabpot added a commit that referenced this pull request Mar 22, 2017
@fabpot
feature #22081 [FrameworkBundle][Validator] Move Validator passes to …
c73009a 
…the component (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle][Validator] Move Validator passes to the component

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

0b741da Move AddValidatorInitializersrPass & AddConstraintValidatorsPass to the Validator
@chalasr chalasr deleted the validator-passes branch March 22, 2017 22:00
@fabpot fabpot mentioned this pull request May 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

Assignees
No one assigned
Labels
Deprecation Feature FrameworkBundle Status: Needs Review Validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @fabpot @xabbuh @carsonbot