Skip to content

[Lock] Don't call blindly the redis client #22117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

jderusse
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Actual code rely on controls on the constructor. This PR add an assertion to avoid futur bugs

@jderusse jderusse changed the title Don't call blindly the redis client [Lock] Don't call blindly the redis client Mar 22, 2017
@fabpot
Copy link
Member

fabpot commented Mar 22, 2017

Thank you @jderusse.

@fabpot fabpot merged commit e4db018 into symfony:master Mar 22, 2017
fabpot added a commit that referenced this pull request Mar 22, 2017
This PR was merged into the 3.3-dev branch.

Discussion
----------

[Lock] Don't call blindly the redis client

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Actual code rely on controls on the constructor. This PR add an assertion to avoid futur bugs

Commits
-------

e4db018 Don't call blindly the redis client
@jderusse jderusse mentioned this pull request Mar 22, 2017
4 tasks
@jderusse jderusse deleted the lock-redis-check branch March 23, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants