[Lock] Adjust lock delay to avoid false error tests #22119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
0a11ecc to
33f2a9a
Compare
|
Thank you @jderusse. |
fabpot
added a commit
that referenced
this pull request
Mar 22, 2017
…russe) This PR was merged into the 3.3-dev branch. Discussion ---------- [Lock] Adjust lock delay to avoid false error tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Adjust the clockDelay to fix tests This test is here to: T0. * Fork A, B, C T1. * A acquire Lock then start sleeping for 3*clockDelay * B start sleeping for 1*clockDelay * C start sleeping for 1*clockDelay T2 * B wakeup AND try to acquire lock in wait mode * C wakeup AND try to acquire lock in non wait mode (lock should be till acquired by A) T4 * A release Lock * B acquire lock and release it At the end, this tests assert than: * A acquire and delete the lock * B acquire and delete the lock * C failed to acquire the lock The point is, this test is time sensitive, and if the fork is too slow, A, B and C are not synchronized and C is able to acquire Lock. This PR adjuste clock delay to reduce false failures Commits ------- 33f2a9a Adjust lock delay to avoid false error tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the clockDelay to fix tests
This test is here to:
T0.
T1.
T2
T4
At the end, this tests assert than:
The point is, this test is time sensitive, and if the fork is too slow, A, B and C are not synchronized and C is able to acquire Lock.
This PR adjuste clock delay to reduce false failures