[WebProfilerBundle] Fix rendering empty cache calls #22127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Mar 23, 2017
| <h4>Calls for '{{ name }}'</h4> | ||
| {% if calls|length == 0 %} | ||
| <div class="empty"> | ||
| <p>No calls</p> |
There was a problem hiding this comment.
Trailing dot removed intentionally. There's some inconsistency though around different panels.
|
Favoring #22129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
The bug is real, given the current intention.
Regarding makeup; i think for now this is the most consistent. However the page is extremely long by default, so yes, this extra empty block margin makes it even longer (but still it looks better IMO).
Somewhat related to #21065 (comment)