Restore SessionListener class for backward compatibility with Silex #22171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SessionListener and TestSessionListener are extended outside of Symfony in Silex. These classes cannot be renamed.
0fc60f4 to
857db92
Compare
857db92 to
54ed309
Compare
54ed309 to
7b0ce40
Compare
|
Looking at the failure, the core issue is: |
|
I'm going to take over this one. To me, we just need to remove |
|
Removing the
|
fabpot
added a commit
that referenced
this pull request
Mar 31, 2017
…*SessionListener (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpKernel] Dont implement ServiceSubscriberInterface on *SessionListener | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22171, silexphp/Silex#1496 | License | MIT | Doc PR | - Implementing `ServiceSubscriberInterface` creates a dep on the DI component, which Silex can't afford. Let's revert that part. @GromNaN can you please confirm this fixes your issue? Commits ------- 7cd90f5 [HttpKernel] Dont implement ServiceSubscriberInterface on *SessionListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #21625 renamed the classes from
Symfony\Component\HttpKernel\EventListener:...\SessionListenerto...\AbstractSessionListener...\TestSessionListenerto...\AbstractTestSessionListenerThis is breaking the Silex class that extends it.
To keep the backward compatibility, abstract classes are renamed to their original names and subclasses using container injection are prefixed by
ContainerAware.Also added some tests.