[Process] Fix bug which wiped or mangled env vars #22183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcdawkins
added a commit
to platformsh/legacy-cli
that referenced
this pull request
Mar 27, 2017
| public function testEnvBackupDoesNotDeleteExistingVars() | ||
| { | ||
| putenv('existing_var=foo'); | ||
| $process = $this->getProcess('echo "$new_test_var"'); |
There was a problem hiding this comment.
this command does not work on Windows (see appveyor failure)
so we should either make the test pass o Windows, or at least skip it
There was a problem hiding this comment.
Thanks - resolved
|
Thank you @pjcdawkins. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2017
…ins) This PR was squashed before being merged into the 3.2 branch (closes #22183). Discussion ---------- [Process] Fix bug which wiped or mangled env vars | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Fixing (and testing) a one-character bug introduced in a recent commit symfony/process@7d21c4a Commits ------- 9439237 [Process] Fix bug which wiped or mangled env vars
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing (and testing) a one-character bug introduced in a recent commit symfony/process@7d21c4a