[DependencyInjection] Support local binding #22187

GuilhemN · 2017-03-27T18:22:38Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#22167, #23718
License	MIT
Doc PR

A great idea came out on Slack about local bindings.
We could allow injecting services based on type hints on a per service/file basis:
services:
    _defaults:
        bind:
            BarInterface: '@usual_bar'

    Foo:
        bind:
            BarInterface: '@alternative_bar'
            $quz: 'quzvalue'
This way, @usual_bar will be injected in any parameter type hinted as BarInterface (in a constructor or a method signature), but only for this service/file.
Note that bindings could be unused, giving a better solution than #22152 to #21711.

As named parameters are usable in arguments, bindings could be usable in arguments too:
services:
    Foo:
        arguments:
            BarInterface: '@bar'

~~Named parameters aren't supported yet.~~

Edit:

Note that bindings could be unused

Current behavior is throwing an exception when a binding is not used at all, in no services of a file if it was inherited from _defaults or in no services created from a prototype.
It will pass if the bindings are all used in at least one service.

nicolas-grekas

The target looks good to me, named args should be handled to make the feature complete to me.
Here are some friendly comments to help move forward.

nicolas-grekas · 2017-03-28T08:58:44Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+     */
+    protected function processValue($value, $isRoot = false)
+    {
+        if (!$value instanceof Definition || empty($value->getBindings())) {


~~empty($value->getBindings())~~ > !$bindings = $value->getBindings()

nicolas-grekas · 2017-03-28T09:00:57Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+            $class = $parameterBag->resolveValue($class);
+        }
+
+        $bindings = $value->getBindings();


to be removed, see above

nicolas-grekas · 2017-03-28T09:01:14Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+        $parameterBag = $this->container->getParameterBag();
+
+        if ($class = $value->getClass()) {
+            $class = $parameterBag->resolveValue($class);


should be removed (also from ResolveNamedArgumentsPass): params have already been resolved at this stage.

nicolas-grekas · 2017-03-28T10:13:36Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+
+        foreach ($calls as $i => $call) {
+            list($method, $arguments) = $call;
+            $method = $parameterBag->resolveValue($method);


same comment (and same cleanup to do in ResolveNamedArgumentsPass)

nicolas-grekas · 2017-03-28T10:19:38Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+                ksort($arguments);
+                $calls[$i][1] = $arguments;
+            }
+        }


$bindings should be allowed to contain $named args, so that it can be used with scalar/array params also.
$bindings could also be validated: what about throwing when a key doesn't match any existing class/interface? That would help people spot typos easily.

$bindings should be allowed to contain $named args, so that it can be used with scalar/array params also.

Yes I have to do that :)

$bindings could also be validated: what about throwing when a key doesn't match any existing class/interface? That would help people spot typos easily.

What if the class/interface doesn't exist/is not loaded yet? Is this an unsupported case?

What if the class/interface doesn't exist

unsupported yes, DX is way more important than supporting funky edge cases

nicolas-grekas · 2017-03-28T10:23:34Z

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

+
+        foreach ($defaults['bindings'] as $binding) {
+            if (!$binding->hasAttribute('id')) {
+                throw new InvalidArgumentException(sprintf('The binding service id for tag "<defaults>" in %s must be defined.', $file));


should allow $named args

nicolas-grekas · 2017-03-28T10:23:47Z

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

@@ -333,6 +341,22 @@ private function parseDefinition(\DOMElement $service, $file, array $defaults =
            $definition->addAutowiringType($type->textContent);
        }

+        $bindingNodes = $this->getChildren($service, 'binding');
+        if (empty($bindingNodes) && !empty($defaults['bindings'])) {


nicolas-grekas · 2017-03-28T10:23:56Z

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

+        $bindings = array();
+        foreach ($bindingNodes as $binding) {
+            if (!$binding->hasAttribute('id')) {
+                throw new InvalidArgumentException(sprintf('The "id" attribute for binding type "%s" for service "%s" in %s must be defined.', $type, (string) $service->getAttribute('id'), $file));


$named args

which means we need a type="service/collection" attribute on xml

nicolas-grekas · 2017-03-28T10:25:31Z

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

+                throw new InvalidArgumentException(sprintf('The "id" attribute for binding type "%s" for service "%s" in %s must be defined.', $type, (string) $service->getAttribute('id'), $file));
+            }
+
+            $bindings[$binding->getAttribute('type')] = new Reference($binding->getAttribute('id'));


type should renamed to eg "key" (to allow "type" to be used as suggested previously)

nicolas-grekas · 2017-03-28T10:27:11Z

src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php

+
+            $definition->setBindings($bindings);
+        } elseif (isset($defaults['bindings'])) {
+            $definition->setBindings($defaults['bindings']);


I'd expect default bindings to be merged with service ones, don't you?

GuilhemN · 2017-03-28T17:27:32Z

@nicolas-grekas thanks for you comments, they should all be fixed now 😃

nicolas-grekas · 2017-03-28T17:46:30Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+        }
+
+        foreach ($bindings as $key => $binding) {
+            if ($key && '$' === $key[0]) {


$key can be a number at this stage (as bogus as it would be) - then $key[0] would break
!isset($key[0]) || '$' === $key[0] instead?

A number should not be supported so I'd say isset($key[0]) && '$' === $key[0], thanks!

nicolas-grekas · 2017-03-28T17:48:18Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+                continue;
+            }
+
+            if (null !== $binding && !$binding instanceof Reference) {


what about allowing Definition also?

nicolas-grekas · 2017-03-28T19:38:26Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+                throw new InvalidArgumentException(sprintf('Invalid value for binding type "%s" for service "%s": expected null, an instance of %s or an instance of %s, %s given.', $key, (string) $this->currentId, Reference::class, Definition::class, gettype($binding)));
+            }
+
+            if (!class_exists($key) && !interface_exists($key)) {


missing false as 2nd arg of interface_exists

but thinking more about this, you told me you would prefer throwing when a binding is never used.
we can do that: we just need to move the deep clone that is done in FileLoader to ResolveDefinitionInheritancePass!
I'd prefer this over this class_exists check myself (because it makes things context-sensitive)

nicolas-grekas · 2017-03-28T19:39:12Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+            }
+
+            if (null !== $binding && !$binding instanceof Reference && !$binding instanceof Definition) {
+                throw new InvalidArgumentException(sprintf('Invalid value for binding type "%s" for service "%s": expected null, an instance of %s or an instance of %s, %s given.', $key, (string) $this->currentId, Reference::class, Definition::class, gettype($binding)));


for binding "key" (reusing vocabulary from XmlLoader)

nicolas-grekas · 2017-03-28T19:39:34Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+            }
+
+            if (!class_exists($key) && !interface_exists($key)) {
+                throw new InvalidArgumentException(sprintf('Invalid binding type "%s" for service "%s": this class/interface does not exist.', $key, $this->currentId));


s/type/key
this class or interface

nicolas-grekas · 2017-03-28T19:41:56Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+            }
+
+            foreach ($reflectionMethod->getParameters() as $key => $parameter) {
+                if (isset($arguments[$key])) {


array_key_exists

in fact, AutowirePass has a trick here, which we should account for: null is not autowired, but an empty string with a non-internal type-hint triggers autowiring - we should do the binding here also in this case

nicolas-grekas · 2017-03-28T19:50:29Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveNamedArgumentsPass.php

@@ -50,21 +44,39 @@ protected function processValue($value, $isRoot = false)
                    $resolvedArguments[] = $argument;
                    continue;
                }
-                if ('' === $key || '$' !== $key[0]) {
+
+                if ('' === $key || ('$' !== $key[0] && !class_exists($key) && !interface_exists($key))) {


here we don't need the class_exists check: we should just throw when a binding is not used (as done for $named args already), this will make things context-free again

nicolas-grekas · 2017-03-28T19:51:28Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveNamedArgumentsPass.php

                        $resolvedArguments[$j] = $argument;

                        continue 2;
                    }
                }

-                throw new InvalidArgumentException(sprintf('Unable to resolve service "%s": method "%s::%s" has no argument named "%s". Check your service definition.', $this->currentId, $class, $method, $key));
+                throw new InvalidArgumentException(sprintf('Unable to resolve service "%s": method "%s::%s" has no argument type hinted as "%s". Check your service definition.', $this->currentId, $value->getClass(), $method, $key));


type-hinted (with a dash)

nicolas-grekas · 2017-03-28T19:56:40Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+        }
+
+        $calls = $value->getMethodCalls();
+        $calls[] = array(null, $value->getArguments()); // constructor


instead of null: $class->hasConstructor() ? $class->getConstructor()->name : '__construct'
which implies moving the getReflectionClass call outside of the getReflectionMethod call, which is nice because it is currently in a loop for no reason.
Same on ResolveNamedArgsPass of course.

lunetics · 2017-03-30T01:36:54Z

+1, how much is left to do? can't await it!

GuilhemN · 2017-03-30T05:05:53Z

For me it's ready.
Maybe we can do something about #22187 (comment) but I don't see how to improve this part of the code for now.

ro0NL

services:
    Foo:
        arguments:
            BarInterface: '@bar'

Not sure if BarInterface has a special meaning here? given only integer or $named arguments are allowed.

edit: ah i see the change in ResolveNamedArguments now 👍

ro0NL · 2017-03-30T08:00:36Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+                continue;
+            }
+
+            if (null !== $binding && !$binding instanceof Reference && !$binding instanceof Definition) {


shouldnt this check go first?

No, any value is allowed for named arguments.
Though i have to add it in the other pass.

that is true 👍

ro0NL · 2017-03-30T08:01:23Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+        $calls = $value->getMethodCalls();
+
+        $constructor = $reflectionClass->getConstructor();
+        $calls[] = array(null !== $constructor ? $constructor->name : '__construct', $value->getArguments()); // constructor


comment not needed imo. this is obvious.

nicolas-grekas

here are some comments for another iteration.
can you look at descriptors also please?

nicolas-grekas · 2017-04-01T12:26:09Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+            }
+
+            if (!class_exists($key) && !interface_exists($key, false)) {
+                throw new InvalidArgumentException(sprintf('Invalid binding key "%s" for service "%s": this class/interface does not exist.', $key, $this->currentId));


class or interface (instead of the slash)

nicolas-grekas · 2017-04-01T12:27:53Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+
+        $class = $value->getClass();
+        if (!$class) {
+            throw new InvalidArgumentException(sprintf('Unable to resolve service "%s": the class is not set.', $this->currentId));


no need for this block, autowire pass does:
if (!$reflectionClass = $this->container->getReflectionClass($definition->getClass(), true)) {
which is enough

nicolas-grekas · 2017-04-01T12:28:09Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+            throw new InvalidArgumentException(sprintf('Unable to resolve service "%s": the class is not set.', $this->currentId));
+        }
+
+        if (!$reflectionClass = $this->container->getReflectionClass($class)) {


see previous comment

nicolas-grekas · 2017-04-01T12:39:49Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+                }
+
+                if (array_key_exists('$'.$parameter->name, $bindings)) {
+                    $arguments[$key] = $bindings['$'.$parameter->name];


to help spot typos in named args, what about keeping a pass-wide property of all named args and their usages, and throw for unused ones at the end of the pass?

nicolas-grekas · 2017-04-01T18:00:37Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveNamedArgumentsPass.php

+
+                if (null === $parameters) {
+                    if (!$class) {
+                        throw new InvalidArgumentException(sprintf('Unable to resolve service "%s": the class is not set.', $this->currentId));


not needed, already checked just below

GuilhemN · 2017-04-01T20:12:02Z

can you look at descriptors also please?

As for named arguments the updated arguments are shown by the descriptors, so I agree with you, I don't think we need to support the bindings in the descriptors.

to help spot typos in named args, what about keeping a pass-wide property of all named args and their usages, and throw for unused ones at the end of the pass?

I found a way to throw an error when a binding is used nowhere so no need to do this anymore.

…g (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Add "factory" support to named args and autowiring | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - To me, factories are expected to work named arguments. Doing so also unlocks supporting them when autowiring, and will benefit #22187 soon. Commits ------- 27470de [DI] Add "factory" support to named args and autowiring

nicolas-grekas · 2017-04-05T16:46:27Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+            }
+        }
+
+        if ($value->getFactory() || null !== $constructor) {


missing logic update?

nicolas-grekas · 2017-04-05T16:47:17Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveNamedArgumentsPass.php


                if (null === $parameters) {
                    $r = $this->getReflectionMethod($value, $method);
                    $class = $r instanceof \ReflectionMethod ? $r->class : $this->currentId;
                    $parameters = $r->getParameters();
                }

+                if ('$' === $key[0]) {


breaks when $key === ''?

yes, added a isset check

GuilhemN · 2017-07-24T09:15:18Z

The build failure is because this is not yet in master.

nicolas-grekas · 2017-07-31T07:30:13Z

this PR description could be enhanced to emphasis the use of mapping arguments to parameters, because that's a common need, see #23718

javiereguiluz · 2017-07-31T07:30:45Z

Can we improve the DX of this feature? If this comment by @GuilhemN is correct, this is how the feature works now:

services:
    _defaults:
        autowire: true
        autoconfigure: true
        public: false

        bind:
            $argument1: '%kernel.project_dir%'
            $argument2: '%app.container_param%'
            $argument3: '%app.another_param%'

    # ...

This is my proposal:

services:
    _defaults:
        autowire: true
        autoconfigure: true
        public: false
        arguments:
            $argument1: '%kernel.project_dir%'
            $argument2: '%app.container_param%'
            $argument3: '%app.another_param%'

    # ...

My reasoning:

This feature is about defining the default value of scalar arguments, so "_defaults.arguments" sounds natural.
We wouldn't introduce yet another config option ("bind").

GuilhemN · 2017-07-31T07:45:16Z

services:
    _defaults:
        autowire: true
        autoconfigure: true
        public: false

    bind:
        $argument1: '%kernel.project_dir%'
        $argument2: '%app.container_param%'
        $argument3: '%app.another_param%'

    # ...

bind is used under _defaults or in a service definition, it's not a special option.

@javiereguiluz arguments are not the same, they can only be used in the constructor while bindings are meant to be used in the constructor, method calls and in action arguments.
Bindings are also optional (no need to be used in all services) while arguments must be used in every service of the file/resource.

This feature is about defining the default value of scalar arguments, so "_defaults.arguments" sounds natural.

That's just one use case :) It can also be used in libraries as a totally predictable autowiring, to deal with multiple instance of the same class, to have a nicer syntax to replace services in action arguments and so on.
And as I said earlier arguments are far more limited, having a different behavior in _defaults for arguments would be weird.

nicolas-grekas

Small remaining comments.
This should be merged now, we already identified several cases where this feature is useful and would be a nice addition.
If we don't merge, we cannot improve it later if needed - nor experience it for real.

nicolas-grekas · 2017-08-07T20:57:24Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+     */
+    protected function processValue($value, $isRoot = false)
+    {
+        if ($value instanceof TypedReference) {


&& $value->getType() === (string) $value because typed reference can be configured with an explicit id (as done in autowiring pass L330 in getAutowiredReference)
needs a test case

nicolas-grekas · 2017-08-07T20:59:17Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php

+            return parent::processValue($value, $isRoot);
+        }
+
+        foreach ($value->getBindings() as $key => $binding) {


foreach ($bindings as ...

nicolas-grekas · 2017-08-07T21:10:11Z

src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

+        $bindings = $this->getArgumentsAsPhp($service, 'bind', $file);
+        if (isset($defaults['bind'])) {
+            // deep clone, to avoid multiple process of the same instance in the
+            // passes


comment should be on one line
// deep clone, to avoid processing the same definitions several times in compiler passes

nicolas-grekas · 2017-08-07T21:12:39Z

src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php

@@ -519,6 +534,22 @@ private function parseDefinition($id, $service, $file, array $defaults)
            }
        }

+        if (isset($defaults['bind']) || isset($service['bind'])) {
+            // deep clone, to avoid multiple process of the same instance in the


nicolas-grekas · 2017-08-08T05:54:03Z

@javiereguiluz here is a typical example:

services:
  _defaults:
    bind:
      $projectDir: '%kernel.project_dir%'

This means that any arguments (constructor or setter) that are named $projectDir for services defined in the current file will get the kernel.project_dir value, provided the services don't themselves explicitly set any other values of course.

~~We could even put that specific line in the default flex config.~~ (no, because that would trigger an "unused binding" kind of exception, we preferred to ease spotting typos here)

Do we get your vote? :)

GuilhemN · 2017-08-08T08:49:33Z

@nicolas-grekas comments fixed :)

nicolas-grekas · 2017-08-09T09:26:34Z

Thank you @GuilhemN.

carsonbot added Status: Needs Review DependencyInjection Feature labels Mar 27, 2017

GuilhemN mentioned this pull request Mar 27, 2017

[DependencyInjection] Support local interface/class bindings #22167

Closed

GuilhemN force-pushed the BINDING branch 2 times, most recently from d159e0d to f7539be Compare March 27, 2017 18:43

nicolas-grekas reviewed Mar 28, 2017

View reviewed changes

nicolas-grekas added this to the 3.3 milestone Mar 28, 2017

GuilhemN force-pushed the BINDING branch 2 times, most recently from ec233a9 to a4706d9 Compare March 28, 2017 17:26

nicolas-grekas reviewed Mar 28, 2017

View reviewed changes

GuilhemN force-pushed the BINDING branch from a8b161d to c4cc22d Compare March 28, 2017 17:56

nicolas-grekas reviewed Mar 28, 2017

View reviewed changes

ro0NL reviewed Mar 30, 2017

View reviewed changes

nicolas-grekas reviewed Apr 1, 2017

View reviewed changes

GuilhemN force-pushed the BINDING branch 3 times, most recently from 3101fb3 to 94d6da9 Compare April 1, 2017 20:05

GuilhemN force-pushed the BINDING branch from 13e4724 to 0c7717a Compare April 3, 2017 19:25

nicolas-grekas mentioned this pull request Apr 4, 2017

[DI] Add "factory" support to named args and autowiring #22277

Merged

GuilhemN force-pushed the BINDING branch from 0c7717a to 024e550 Compare April 4, 2017 17:20

GuilhemN force-pushed the BINDING branch from 024e550 to 77a84cd Compare April 4, 2017 18:30

nicolas-grekas reviewed Apr 5, 2017

View reviewed changes

GuilhemN added 5 commits July 23, 2017 14:47

[DependencyInjection] Support local binding

6e1be02

Support TypedReference

f179bb6

Use bindings for controller arguments

e3c5999

Remove an elseif

316b818

Fixes

24b29d9

GuilhemN force-pushed the BINDING branch from 0477a61 to 24b29d9 Compare July 23, 2017 12:48

GuilhemN mentioned this pull request Jul 30, 2017

[RFC] Proposal to simplify the autowiring of container parameters #23718

Closed

nicolas-grekas approved these changes Aug 7, 2017

View reviewed changes

fixes

e30e63e

Test TypedReference support

35fcc43

GuilhemN force-pushed the BINDING branch from 9765d35 to 35fcc43 Compare August 8, 2017 08:55

ogizanagi approved these changes Aug 8, 2017

View reviewed changes

nicolas-grekas added Status: Reviewed and removed Status: Needs Review labels Aug 8, 2017

nicolas-grekas closed this in fd16993 Aug 9, 2017

GuilhemN deleted the BINDING branch August 9, 2017 10:47

xabbuh mentioned this pull request Aug 11, 2017

[DI] Localbinding (bind) support symfony/symfony-docs#8276

Closed

This was referenced Aug 27, 2017

[Debug] Remove false-positive check in DebugClassLoader #23989

Merged

Autowiring in abstract classes with DI in Symfony 3.3, is it possible? #23998

Closed

nicolas-grekas mentioned this pull request Sep 26, 2017

[DependencyInjection] Service defaults by trait #24327

Closed

This was referenced Oct 18, 2017

Release v3.4.0-BETA1 #24609

Merged

Release v4.0.0-BETA1 #24612

Merged

[DependencyInjection] Support local binding #22187

[DependencyInjection] Support local binding #22187

Conversation

GuilhemN commented Mar 27, 2017 • edited by nicolas-grekas Loading

nicolas-grekas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas Mar 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas Mar 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuilhemN commented Mar 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas Mar 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lunetics commented Mar 30, 2017

GuilhemN commented Mar 30, 2017

ro0NL left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuilhemN commented Apr 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuilhemN commented Jul 24, 2017

nicolas-grekas commented Jul 31, 2017 • edited Loading

javiereguiluz commented Jul 31, 2017 • edited by nicolas-grekas Loading

GuilhemN commented Jul 31, 2017 • edited Loading

nicolas-grekas left a comment

Choose a reason for hiding this comment

nicolas-grekas Aug 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas commented Aug 8, 2017 • edited Loading

GuilhemN commented Aug 8, 2017

nicolas-grekas commented Aug 9, 2017

GuilhemN commented Mar 27, 2017 •

edited by nicolas-grekas

Loading

nicolas-grekas Mar 28, 2017 •

edited

Loading

nicolas-grekas Mar 28, 2017 •

edited

Loading

GuilhemN commented Mar 28, 2017 •

edited

Loading

nicolas-grekas Mar 28, 2017 •

edited

Loading

ro0NL left a comment •

edited

Loading

nicolas-grekas commented Jul 31, 2017 •

edited

Loading

javiereguiluz commented Jul 31, 2017 •

edited by nicolas-grekas

Loading

GuilhemN commented Jul 31, 2017 •

edited

Loading

nicolas-grekas Aug 7, 2017 •

edited

Loading

nicolas-grekas commented Aug 8, 2017 •

edited

Loading