[HttpKernel] minor: add ability to construct with headers on http exceptions #22228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4a21dd to
c9fd589
Compare
|
All the array_merge could be replaced by a simple affectation: |
|
@nicolas-grekas Thanks! Good spot, will update. |
c9fd589 to
098006f
Compare
stloyd
suggested changes
Apr 9, 2017
src/Symfony/Component/HttpKernel/Exception/UnauthorizedHttpException.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Exception/TooManyRequestsHttpException.php
Outdated
Show resolved
Hide resolved
|
An oversight, will fix the others up also. |
|
Status: needs work |
098006f to
612fb59
Compare
|
Updated. |
nicolas-grekas
approved these changes
Oct 8, 2017
xabbuh
approved these changes
Oct 8, 2017
fabpot
approved these changes
Oct 8, 2017
|
Thank you @gsdevme. |
fabpot
added a commit
that referenced
this pull request
Oct 8, 2017
…ers on http exceptions (gsdevme) This PR was merged into the 4.0-dev branch. Discussion ---------- [HttpKernel] minor: add ability to construct with headers on http exceptions | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This adds the ability to set the headers for the exception within the constructor. With alot of the following exceptions its sometimes very useful to be able to set the headers. For example with a reverse proxy cache (Varnish) if you want to match the `Retry-After` with a Varnish cache header to protect the backend. I see that `setHeaders()` did get added 6a1080f but that means the exception needs to be assigned to a variable and set and then thrown, it also doesn't merge with the existing header set in some of the constructors. ~~I've chosen to `array_merge()` where key/values~~ were being set within the constructor as I think this is the most useful and 'correct' whereas `setHeaders` is explicit that its setting not amending or adding to. Commits ------- 612fb59 [HttpKernel] minor: add ability to construct with headers on http exceptions
Merged
|
For future reference although this has a milestone of 3.4, its only in 4.0+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set the headers for the exception within the constructor.
With alot of the following exceptions its sometimes very useful to be able to set the headers. For example with a reverse proxy cache (Varnish) if you want to match the
Retry-Afterwith a Varnish cache header to protect the backend.I see that
setHeaders()did get added 6a1080f but that means the exception needs to be assigned to a variable and set and then thrown, it also doesn't merge with the existing header set in some of the constructors.I've chosen towere being set within the constructor as I think this is the most useful and 'correct' whereasarray_merge()where key/valuessetHeadersis explicit that its setting not amending or adding to.