[DI] Reduce complexity of autowiring #22256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Apr 3, 2017
| // no default value? Then fail | ||
| if (!$parameter->isOptional()) { | ||
| if (!$parameter->isDefaultValueAvailable()) { |
There was a problem hiding this comment.
as spotted here: #22254 (comment)
|
@nicolas-grekas I let you merge this one |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 4, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Reduce complexity of autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no (tweaking existing ones) | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - - optional args are autowired - methods with only optional args are autowired - default values of required args when possible Both first changes remove the behavior delta between constructors and setters, and is expected to me now that things are more explicit. This reduces the "know-how" requirements for using autowiring and is easier to get correct intuitively. The 3rd change plays nice with named args. Commits ------- 146f074 [DI] Reduce complexity of autowiring
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both first changes remove the behavior delta between constructors and setters, and is expected to me now that things are more explicit. This reduces the "know-how" requirements for using autowiring and is easier to get correct intuitively. The 3rd change plays nice with named args.