[DI] Fix second auto-registration #22311
Conversation
|
This break was caused by #22254. @nicolas-grekas That PR strikes me itself as a BC break. This PR fixes the linked issue #22309... are there any other behavior changes due to #22254? And if so (and if we're ok with those minor breaks, because it was a bug), is the user seeing a very clear error when they upgrade? I'm uncomfortable with behavior changes in patch releases (but also realize it's trick with bugs) |
|
#22254 fixes a bug, that hits people hard and in unexpected ways. For some, it looked like it worked, for others, it just didn't work. The discussion is in the PR. Every bug fix is a BC break. We couldn't live with this one a "bug-as-a-feature". This PR is fixes a "return" that I inadvertently added in the code (for a behavior that missed a test case). |
|
Thank you @nicolas-grekas. |
This PR was merged into the 2.8 branch. Discussion ---------- [DI] Fix second auto-registration | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22309 | License | MIT | Doc PR | - My bad Commits ------- c02de84 [DI] Fix second auto-registration
My bad