Skip to content

[Workflow] Move ValidateWorkflowsPass to the Workflow component #22313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2017
Merged

[Workflow] Move ValidateWorkflowsPass to the Workflow component #22313

merged 1 commit into from
Apr 14, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Apr 6, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Continues #21284

@chalasr chalasr changed the title Move ValidateWorkflowsPass to the Workflow component [Workflow] Move ValidateWorkflowsPass to the Workflow component Apr 6, 2017
@chalasr chalasr force-pushed the workflow-pass branch 2 times, most recently from c7e802a to 3b9f1a8 Compare April 6, 2017 17:18
@chalasr chalasr mentioned this pull request Apr 6, 2017
Closed
11 tasks
@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Apr 7, 2017
@chalasr
Copy link
Member Author

chalasr commented Apr 14, 2017

Rebased, this is ready.

xabbuh
xabbuh requested changes Apr 14, 2017
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symfony/dependency-injection must now be added to the require-dev section of the Workflow component's composer.json file.

@chalasr
Copy link
Member Author

chalasr commented Apr 14, 2017

@xabbuh the rebase went wrong, fixed now.

@fabpot
Copy link
Member

fabpot commented Apr 14, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 8fe122f into symfony:master Apr 14, 2017
fabpot added a commit that referenced this pull request Apr 14, 2017
@fabpot
feature #22313 [Workflow] Move ValidateWorkflowsPass to the Workflow …
ac5cfee 
…component (chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[Workflow] Move ValidateWorkflowsPass to the Workflow component

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Continues #21284

Commits
-------

8fe122f Move ValidateWorkflowsPass to the Workflow component
@chalasr chalasr deleted the workflow-pass branch April 15, 2017 10:50
@fabpot fabpot mentioned this pull request May 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Deprecation Feature Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @fabpot @xabbuh @nicolas-grekas @carsonbot