[HttpKernel][FrameworkBundle] Dump container logs in Kernel, to have them also on errors #22314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them also on errors
b5b702c to
a8b8334
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2017
…ernel, to have them also on errors (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpKernel][FrameworkBundle] Dump container logs in Kernel, to have them also on errors | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Inspecting container failures without the logs is hard, let's have them at hand. This should not be the responsibility of a compiler pass. Commits ------- a8b8334 [HttpKernel][FrameworkBundle] Dump container logs in Kernel, to have them also on errors
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspecting container failures without the logs is hard, let's have them at hand. This should not be the responsibility of a compiler pass.