[WebServerBundle] added a way to dump current status host/port/address when getting the status #22316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is how I'm using this in my Makefile: |
…s when getting the status
cf724dd to
b417b62
Compare
ro0NL
reviewed
Apr 6, 2017
| @@ -35,6 +35,7 @@ protected function configure() | |||
| ->setName('server:status') | |||
| ->setDefinition(array( | |||
| new InputOption('pidfile', null, InputOption::VALUE_REQUIRED, 'PID file'), | |||
| new InputOption('filter', null, InputOption::VALUE_REQUIRED, 'The value to display (one of port, host, or address)'), | |||
There was a problem hiding this comment.
What about something like --value | --get | --get-value?
| if ($server->isRunning($input->getOption('pidfile'))) { | ||
| list($host, $port) = explode(':', $address = $server->getAddress($input->getOption('pidfile'))); | ||
| if ('address' === $filter) { | ||
| $output->write($address); |
There was a problem hiding this comment.
Should we use OUTPUT_RAW to avoid formatting possible malicious input?
There was a problem hiding this comment.
input comes from the pidfile. If you mess up with it, then you are on your own anyway.
There was a problem hiding this comment.
Note it can also be messed up by some formatter implementation. But fair enough.. what are the odds anyway :)
fabpot
added a commit
that referenced
this pull request
Apr 6, 2017
…ost/port/address when getting the status (fabpot) This PR was merged into the 3.3-dev branch. Discussion ---------- [WebServerBundle] added a way to dump current status host/port/address when getting the status | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Now that the web server can run on an automatically chosen port, it's more complex to integrate it into tests (I want to run some functional tests locally). The `server:status` command gives this information, but not in a machine-readable way. I propose to add a `--filter` flag to fix that: `./bin/console server:status --filter=address` Commits ------- b417b62 [WebServerBundle] added a way to dump current status host/port/address when getting the status
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the web server can run on an automatically chosen port, it's more complex to integrate it into tests (I want to run some functional tests locally).
The
server:statuscommand gives this information, but not in a machine-readable way.I propose to add a
--filterflag to fix that:./bin/console server:status --filter=address