Skip to content

[DI] Report cascades of autowiring error messages #22323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Apr 6, 2017

Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Enhance DX by reporting the cascade of errors that lead to an autowiring error, eg:
capture du 2017-04-07 00-03-28

Also contains a cleanup found along the way: processing of nested definitions should happen before the current one so that TypedReference are processed only once.

@nicolas-grekas nicolas-grekas changed the title [DI] Reported cascades of autowiring error messages [DI] Reporte cascades of autowiring error messages Apr 6, 2017
@fabpot fabpot changed the title [DI] Reporte cascades of autowiring error messages [DI] Report cascades of autowiring error messages Apr 6, 2017
@fabpot
Copy link
Member

fabpot commented Apr 6, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 6c0f5e3 into symfony:master Apr 6, 2017
fabpot added a commit that referenced this pull request Apr 6, 2017
…olas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Report cascades of autowiring error messages

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Enhance DX by reporting the cascade of errors that lead to an autowiring error, eg:
![capture du 2017-04-07 00-03-28](https://cloud.githubusercontent.com/assets/243674/24777441/ac1fb118-1b25-11e7-9459-ecdf13e79798.png)

Also contains a cleanup found along the way: processing of nested definitions should happen before the current one so that TypedReference are processed only once.

Commits
-------

6c0f5e3 [DI] Reporte cascades of autowiring error messages
@nicolas-grekas nicolas-grekas deleted the di-cascade branch April 7, 2017 06:19
@fabpot fabpot mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants