[Yaml] Failing test for not in-lined map-objects #22392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
commented
Apr 12, 2017
| inner3: { deep1: d, deep2: e } | ||
|
|
||
| YAML; | ||
| $this->assertEquals($expected, $yaml); |
There was a problem hiding this comment.
Current value:
{ outer1: { inner1: b, inner2: c, inner3: { deep1: d, deep2: e } } }
58f4278 to
864d54f
Compare
864d54f to
c8c50cf
Compare
c8c50cf to
beb5f5e
Compare
fabpot
added a commit
that referenced
this pull request
May 11, 2017
…goetas, xabbuh) This PR was merged into the 3.2 branch. Discussion ---------- [Yaml] respect inline level when dumping objects as maps | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22392 | License | MIT | Doc PR | Commits ------- 3cca48c respect inline level when dumping objects as maps 4f5c149 Test case for not in-lined map-objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a failing test case.
ArrayObjectwhen dumped withYaml::DUMP_OBJECT_AS_MAPis always inlined.The
$indentoption looks to be ignored.When using
arrayinstead ofArrayObject, the result is as expected.