Skip to content

Fixed formatting in Security section (in UPGRADE-3.0.md) #22436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Fixed formatting in Security section (in UPGRADE-3.0.md) #22436

merged 1 commit into from
Apr 20, 2017

Conversation

zelazowy
Copy link

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no
License MIT
Doc PR no

Added space (yeah...) to Security section fixing text and code format.

@zelazowy zelazowy changed the title Fixed formatting in Security section Fixed formatting in Security section (in UPGRADE-3.0.md) Apr 14, 2017
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh xabbuh added this to the 3.2 milestone Apr 14, 2017
@fabpot
Copy link
Member

fabpot commented Apr 20, 2017

Good catch, thanks @zelazowy.

@fabpot fabpot merged commit 3bde16c into symfony:master Apr 20, 2017
fabpot added a commit that referenced this pull request Apr 20, 2017
… (zelazowy)

This PR was merged into the 3.3-dev branch.

Discussion
----------

Fixed formatting in Security section (in UPGRADE-3.0.md)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        | no

Added space (yeah...) to Security section fixing text and code format.

Commits
-------

3bde16c Fixed formatting in Security section
@zelazowy zelazowy deleted the patch-1 branch April 21, 2017 06:26
fabpot added a commit that referenced this pull request Jan 21, 2018
This PR was merged into the 2.8 branch.

Discussion
----------

Formatting fix in upgrade 3.0 document

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        | no

Fixes formatting in upgrade file.
This fix was already done in #22436 but applied to 3.2.
Formatting error still exists in 2.8, 3.0, 3.1. I don't know if this was intentional.

Commits
-------

dc6d5e1 Formatting fix in upgrade 3.0 document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants