[Console] Review console.ERROR related behavior #22441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
reviewed
Apr 15, 2017
| use Symfony\Component\Console\Event\ConsoleTerminateEvent; | ||
| use Symfony\Component\EventDispatcher\EventSubscriberInterface; | ||
|
|
||
| /** | ||
| * @author James Halsall <james.t.halsall@googlemail.com> | ||
| * @author Robin Chalas <robin.chalas@gmail.com> | ||
| * | ||
| * @deprecated since version 3.3, to be removed in 4.0. Use ErrorListener instead. |
There was a problem hiding this comment.
This listener has been added in 3.3 (#21003), can be renamed directly :)
e7d321a to
dbdaad7
Compare
dbdaad7 to
a7c67c9
Compare
|
👍 also :) |
stof
requested changes
Apr 25, 2017
| return parent::getException(); | ||
| $r = new \ReflectionProperty($this->error, 'code'); | ||
| $r->setAccessible(true); | ||
| $r->setValue($this->error, $this->exitCode); |
There was a problem hiding this comment.
because the other part of the exception handling uses getCode as the way to set the exit status code from an exception
| parent::__construct($command, $input, $output); | ||
|
|
||
| $this->exception = $exception; | ||
| $this->setException($exception); |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 26, 2017
…as-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [Console] Review console.ERROR related behavior | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR is a follow up of #18140 that I wanted to do since a few weeks. It enhances this work with fixes and behavior changes. It embeds #22435 and resolves issues like the one described in #20808. - makes ConsoleErrorEvent *not* extend the deprecated ConsoleExceptionEvent - replace ConsoleErrorEvent::markErrorAsHandled by ConsoleErrorEvent::setExitCode - triggers the deprecation in a more appropriate moment - renames ExceptionListener to ErrorListener - tweaks the behavior in relation to #22435 Commits ------- a7c67c9 [Console] Review console.ERROR related behavior
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #18140 that I wanted to do since a few weeks.
It enhances this work with fixes and behavior changes.
It embeds #22435 and resolves issues like the one described in #20808.