[WebProfilerBundle] Fix exception rendering #22448
Conversation
e-moe
commented
Apr 15, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #22442 |
| License | MIT |
| Doc PR | none |
| @@ -105,7 +105,7 @@ public function cssAction($token) | |||
|
|
|||
| protected function getTemplate() | |||
| { | |||
| return '@Twig/Exception/'.($this->debug ? 'exception' : 'error').'.html.twig'; | |||
| return '@Twig/Exception/'.($this->debug ? 'exception_full' : 'error').'.html.twig'; | |||
There was a problem hiding this comment.
Not sure if this is the correct fix because it includes the hole HTML page!
There was a problem hiding this comment.
Note that error.html.twig (that is used when debug is false) contains full HTML page too.
|
This looks wrong to me. The The right fix for the symfony full-stack case would be to fix the |
|
thanks for your review. I will try to update this PR in order to apply your suggestions |
|
updated. css taken from |
…iereguiluz) This PR was merged into the 3.3-dev branch. Discussion ---------- Fixed the rendering of exceptions inside the profiler | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22442 | License | MIT | Doc PR | - In #22448 we tried to reuse the same CSS styles as the new exception pages. But that's not enough because it doesn't look good:  --- This PR goes a bit further and tweaks the exception styles slightly to better integrate them. Same page as before:  It should also work reasonably well when the exception message is very long:  Commits ------- 73d81de Fixed the rendering of exceptions inside the profiler
