Skip to content

[HttpKernel] Fix deprecation of Extension::addClassesToCompile() / AddClassesToCachePass #22459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Apr 17, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

As done in #20735

@nicolas-grekas nicolas-grekas force-pushed the changelog-class-compile branch from 67967ff to f4b5784 Compare April 18, 2017 15:57
@nicolas-grekas nicolas-grekas changed the title [HttpKernel] Add changelog entry about Extension::addClassesToCompile() deprecation [HttpKernel] Fix deprecation of Extension::addClassesToCompile() / AddClassesToCachePass Apr 18, 2017
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member

fabpot commented Apr 19, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit f4b5784 into symfony:master Apr 19, 2017
fabpot added a commit that referenced this pull request Apr 19, 2017
…oCompile() / AddClassesToCachePass (nicolas-grekas)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[HttpKernel] Fix deprecation of Extension::addClassesToCompile() / AddClassesToCachePass

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As done in #20735

Commits
-------

f4b5784 [HttpKernel] Fix deprecation of Extension::addClassesToCompile() / AddClassesToCachePass
@nicolas-grekas nicolas-grekas deleted the changelog-class-compile branch April 20, 2017 14:26
@fabpot fabpot mentioned this pull request May 1, 2017
javiereguiluz added a commit to EasyCorp/EasyAdminBundle that referenced this pull request May 8, 2017
…viereguiluz)

This PR was merged into the 1.16.x-dev branch.

Discussion
----------

Don't use the deprecated addClassesToCompile() method

Deprecated since Symfony 3.3 (see symfony/symfony#22459)

Commits
-------

80789c2 Don't use the deprecated addClassesToCompile() method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants