[Security] Numeric passwords comparing bugfix 2 #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… BasePasswordEncoder::comparePasswords haven't been working properly for numeric (plaintype) passwords.
|
Merged. Will appear in master as part of #198 |
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
add simplesamlphp/simplesamlphp SSPSA 201709-01
chalasr
pushed a commit
to chalasr/symfony
that referenced
this pull request
Sep 24, 2020
Fix remaining deprecations
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method BasePasswordEncoder::comparePassword haven't been working for numeric (plaintype) passwords properly because inserted password was converted into integer type a and compared with stored password as a string type. Bugfix changes data type of passwords into string before comparing.
This pull request replace earlier pull request