[FrameworkBundle][HttpKernel] Move httpkernel pass #22620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
requested changes
May 3, 2017
| */ | ||
| public function process(ContainerBuilder $container) | ||
| { | ||
| if (!$container->hasDefinition('cache_clearer')) { |
There was a problem hiding this comment.
same as for your other PR, target service id + collected tag name should be configurable through the constructor, defaulting to the ones used in frameworkbundle.
11 tasks
stof
requested changes
May 3, 2017
|
|
||
| /** | ||
| * Registers the cache clearers. | ||
| * | ||
| * @author Dustin Dobervich <ddobervich@gmail.com> | ||
| */ | ||
| class AddCacheClearerPass implements CompilerPassInterface | ||
| class AddCacheClearerPass extends BaseAddCacheClearerPass |
|
|
||
| /** | ||
| * Registers the cache warmers. | ||
| * | ||
| * @author Fabien Potencier <fabien@symfony.com> | ||
| */ | ||
| class AddCacheWarmerPass implements CompilerPassInterface | ||
| class AddCacheWarmerPass extends BaseAddCacheWarmerPass |
|
@lepiaf The 3.4 branch has been created and is the one that this PR should target (changing the based branch and rebase). |
|
You should also rebase instead of merging. |
chalasr
reviewed
May 25, 2017
| @@ -42,7 +42,7 @@ | |||
| }, | |||
| "conflict": { | |||
| "symfony/config": "<2.8", | |||
| "symfony/dependency-injection": "<3.3", | |||
There was a problem hiding this comment.
the changes on this file should be reverted. You need DI 3.3+ only
|
This makes tests fail for now. |
|
@chalasr sure, I will do it now |
chalasr
requested changes
Jun 21, 2017
| use PriorityTaggedServiceTrait; | ||
|
|
||
| private $cacheWarmerId; | ||
| private $kernelCacheWarmerId; |
| class AddCacheClearerPass implements CompilerPassInterface | ||
| { | ||
| private $cacheClearerId; | ||
| private $kernelCacheClearerId; |
| @@ -95,8 +95,8 @@ public function build(ContainerBuilder $container) | |||
| $this->addCompilerPassIfExists($container, AddConsoleCommandPass::class); | |||
| $container->addCompilerPass(new TranslatorPass()); | |||
| $container->addCompilerPass(new LoggingTranslatorPass()); | |||
| $container->addCompilerPass(new AddCacheWarmerPass()); | |||
| $container->addCompilerPass(new AddCacheClearerPass()); | |||
| $this->addCompilerPassIfExists($container, AddCacheWarmerPass::class); | |||
There was a problem hiding this comment.
No need for using addCompilerPassIfExists() because http-kernel is an hard dependency, addCompilerPass() should be used directly, that will make the build failure more clear also (fail on unexisting class until merged up to master)
fabpot
approved these changes
Jul 6, 2017
|
Thank you @lepiaf. |
fabpot
added a commit
that referenced
this pull request
Jul 6, 2017
…piaf) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][HttpKernel] Move httpkernel pass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | part of #21284 | License | MIT | Doc PR | n/a Move addcachearmer, addcacheclearer compiler pass to httpkernel Commits ------- 83727c7 [FrameworkBundle][HttpKernel] Move addcachearmer, addcacheclearer compiler pass
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move addcachearmer, addcacheclearer compiler pass to httpkernel