[Routing] Expose request in route conditions, if needed and possible #22636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if it's possible to change it, but don't you think that the error message in this case should be a yellow warning with this message? |
|
It's possible... sure ;-) but perhaps out-of-scope for now. The part after Also |
fabpot
reviewed
May 11, 2017
| { | ||
| return class_exists('Symfony\Component\HttpFoundation\Request') | ||
| ? Request::create($this->context->getScheme().'://'.$this->context->getHost().$this->context->getBaseUrl().$pathinfo, $this->context->getMethod(), $this->context->getParameters()) | ||
| : null; |
There was a problem hiding this comment.
will do 👍 i also realized the request is probably not fully functional now; it needs some server params so it can properly resolve baseurl + basepath and such. I wanted to look at that this weekend :)
|
@fabpot this should do. |
| @@ -248,4 +248,16 @@ protected function getExpressionLanguage() | |||
|
|
|||
| return $this->expressionLanguage; | |||
| } | |||
|
|
|||
| protected function createRequest($pathinfo) | |||
There was a problem hiding this comment.
this should be private IMHO
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
…d possible (ro0NL) This PR was squashed before being merged into the 2.7 branch (closes #22636). Discussion ---------- [Routing] Expose request in route conditions, if needed and possible | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16968, #22635 | License | MIT | Doc PR | - given ``` /** * @route("/", name="homepage", condition="request.isXmlHttpRequest()") */ ``` ``` $ app/console route:match / ``` before  after  Commits ------- 016e976 [Routing] Expose request in route conditions, if needed and possible
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
…d and possible (ro0NL) This PR was squashed before being merged into the 2.7 branch (closes #22636). Discussion ---------- [Routing] Expose request in route conditions, if needed and possible | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16968, #22635 | License | MIT | Doc PR | - given ``` /** * @route("/", name="homepage", condition="request.isXmlHttpRequest()") */ ``` ``` $ app/console route:match / ``` before  after  Commits ------- 94371d0 [Routing] Expose request in route conditions, if needed and possible
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given
before
after