[WebServerBundle] fix dependencies #22695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 12, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
commented
May 12, 2017
| @@ -26,6 +27,9 @@ | |||
| "/Tests/" | |||
| ] | |||
| }, | |||
| "conflict": { | |||
| "symfony/dependency-injection": "<3.3" | |||
There was a problem hiding this comment.
Actually, I do not know why the DI component is no required dependency in our bundles. Is there really a use case for using one of bundles without the DI extension/config?
There was a problem hiding this comment.
I think the goal for this bundle is to be able to reuse all the CLI code for Silex too (the DI part here is really just about registering the command services to make them available in Symfony), without creating both a component and a bundle.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
May 12, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [WebServerBundle] fix dependencies | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 84bb34f [WebServerBundle] fix dependencies
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.