Adding autowire alias for AuthenticationUtils #22701
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,6 +68,7 @@ | |||
| <service id="security.authentication_utils" class="Symfony\Component\Security\Http\Authentication\AuthenticationUtils" public="true"> | |||
| <argument type="service" id="request_stack" /> | |||
| </service> | |||
| <service id="Symfony\Component\Security\Http\Authentication\AuthenticationUtils" alias="security.authentication_utils" /> | |||
There was a problem hiding this comment.
The alias should be private (that's how all the other ones are)
There was a problem hiding this comment.
Thanks to you - it is private :). This file has <defaults public="false" />
|
See #22708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthenticationUtils is a public service (used commonly in your
loginAction), so it should be autowireable.We might need to do a full audio of public services to add aliases. Since we're moving in the direction of type-based autowiring, these aliases are sort of the new "public" - it's the list of things you're "supposed" to use.