[FrameworkBundle] Sessions: configurable "use_strict_mode" option for NativeSessionStorage #22730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will also need to update the XML schema definition. |
@xabbuh ? |
|
What I mean is that you will have to update this block to allow to use the new option in XML configs. |
MacDada
added a commit
to MacDada/symfony
that referenced
this pull request
Jun 3, 2017
|
I think being able to configure all options in the config make sense (rebase on current 2.7 as we've just added 4 new options from 7.1). Doing that in a somewhat automated way would be even better if possible. |
|
I don't know how could it be automated. |
793474c to
90e192e
Compare
|
I rebased against 2.7 and squashed my commits into one. |
xabbuh
approved these changes
Jun 18, 2017
|
Thank you @MacDada. |
fabpot
added a commit
that referenced
this pull request
Jun 18, 2017
… option for NativeSessionStorage (MacDada) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Sessions: configurable "use_strict_mode" option for NativeSessionStorage | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT It is currently not possible to configure the `use_strict_mode` option for `NativeSessionStorage` in a proper manner. The reason of this PR: #22352 (comment) It could be considered a new feature, but I wish it wouldn't, as I don't want to do any ugly hacking to get it working. What else could be done? * implement more options from `NativeSessionStorage` in the config? * get rid of duplication somehow (maybe a static method in `NativeSessionStorage` that would return the option list and could be used in `FrameworkExtension`?) * update `FrameworkExtensionTest`? * update `ConfigurationTest`? * update [the docs](https://symfony.com/doc/current/reference/configuration/framework.html#session)? I'm willing to do those if decided. Commits ------- 90e192e Sessions: configurable "use_strict_mode" option for NativeSessionStorage
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to configure the
use_strict_modeoption forNativeSessionStoragein a proper manner.The reason of this PR: #22352 (comment)
It could be considered a new feature, but I wish it wouldn't, as I don't want to do any ugly hacking to get it working.
What else could be done?
NativeSessionStoragein the config?NativeSessionStoragethat would return the option list and could be used inFrameworkExtension?)FrameworkExtensionTest?ConfigurationTest?I'm willing to do those if decided.