[SecurityBundle][Security][Finder] Remove deprecated code paths #22740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase needed to see tests green |
|
Aaaand, green it is. |
ogizanagi
commented
May 18, 2017
| @@ -48,21 +48,8 @@ public function __construct(RequestStack $requestStack = null, UrlGeneratorInter | |||
| * @param CsrfTokenManagerInterface|null $csrfTokenManager A CsrfTokenManagerInterface instance | |||
| * @param string|null $context The listener context | |||
| */ | |||
| public function registerListener($key, $logoutPath, $csrfTokenId, $csrfParameter, CsrfTokenManagerInterface $csrfTokenManager = null/*, $context = null*/) | |||
| public function registerListener($key, $logoutPath, $csrfTokenId, $csrfParameter, CsrfTokenManagerInterface $csrfTokenManager = null, string $context = null) | |||
There was a problem hiding this comment.
Related PR to add the typehint in 3.3: #22757
|
could the commit message be made more explicit? any CHANGELOG missing an update? |
|
I changed the commit message and description and added CHANGELOG entries. |
- [Finder] Removed `ExceptionInterface` - [SecurityBundle] remove `UserPasswordEncoderCommand` BC layer - [Security] remove `LogoutUrlGenerator::registerListener` BC layer
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
…ode paths (ogizanagi) This PR was merged into the 4.0-dev branch. Discussion ---------- [SecurityBundle][Security][Finder] Remove deprecated code paths | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | 1b600b0, 366aefd, 5b7fe85 | License | MIT | Doc PR | N/A Removing my own deprecated stuff from 4.0 :) Commits ------- da202fe [SecurityBundle][Security][Finder] Remove deprecated code paths
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing my own deprecated stuff from 4.0 :)