Allow individual bridges, bundles and components to be used with 4.0 #22742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
May 18, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
xabbuh
requested changes
May 18, 2017
| "symfony/translation": "~2.8|~3.0|~4.0", | ||
| "symfony/yaml": "~2.8|~3.0|~4.0", | ||
| "symfony/security": "~2.8|~3.0|~4.0", | ||
| "symfony/security-acl": "~2.8|~3.0|~4.0", |
There was a problem hiding this comment.
Are we sure that we will bump the release for the Security Acl component? I don't think so (we did not really add anything there).
| "symfony/form": "^2.8.18|^3.2.5|~4.0", | ||
| "symfony/framework-bundle": "^3.2.8|~4.0", | ||
| "symfony/http-foundation": "~2.8|~3.0|~4.0", | ||
| "symfony/security-acl": "~2.8|~3.0|~4.0", |
| "symfony/translation": "~2.8|~3.0", | ||
| "symfony/var-dumper": "~3.3", | ||
| "symfony/browser-kit": "~2.8|~3.0|~4.0", | ||
| "symfony/class-loader": "~2.8|~3.0|~4.0", |
There was a problem hiding this comment.
the ClassLoader component will be removed with Symfony 4
| "symfony/http-foundation": "~3.3", | ||
| "symfony/http-kernel": "~3.3", | ||
| "symfony/cache": "~3.3|~4.0", | ||
| "symfony/class-loader": "~3.2|~4.0", |
xabbuh
approved these changes
May 18, 2017
|
On 3.4, we should allow only 4.0.0 |
| "symfony/dependency-injection": "~2.8|~3.0", | ||
| "ocramius/proxy-manager": "~0.4|~1.0|~2.0" | ||
| "symfony/dependency-injection": "~2.8|~3.0|~4.0", | ||
| "ocramius/proxy-manager": "~0.4|~1.0|~2.0|~4.0" |
| "symfony/http-kernel": "~2.8|~3.0", | ||
| "symfony/process": "~2.8|~3.0" | ||
| "symfony/console": "~2.8.8|~3.0.8|~3.1.2|~3.2|~4.0", | ||
| "symfony/http-kernel": "~2.8|~3.|~4.00", |
|
Done, to do the merge in 4.0: (I can handle the merge if can help) |
| @@ -19,7 +19,7 @@ | |||
| "php": ">=5.5.9" | |||
| }, | |||
| "require-dev": { | |||
| "symfony/process": "^3.2" | |||
| "symfony/process": "^3.2|^4.0.0" | |||
There was a problem hiding this comment.
all ^4.0.0 should be replaced by ~4.0.0
|
Thank you @dunglas. |
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
May 29, 2017
This PR was merged into the 1.16.x-dev branch. Discussion ---------- Allow using Symfony 4 components The "master" branch of Symfony repo is now Symfony 4, so we can start using it (see symfony/symfony#22742 for a similar change for Symfony itself). We'd need to tweak Travis CI too in another PR. Commits ------- dff502f Allow using Symfony 4 components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.