[DI] Remove deprecated dumping an uncompiled container #22764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
missing CHANGELOG updates in components (please check any your other PRs also if any) |
|
@nicolas-grekas like so https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/CHANGELOG.md#300 can be done at once for all components right? |
|
or like so: https://github.com/symfony/symfony/pull/22779/files |
| $this->startClass($options['class'], $options['base_class'], $options['namespace']). | ||
| $this->addFrozenConstructor(). | ||
| $this->addFrozenCompile(). | ||
| $this->addFrozenIsCompiled(). |
There was a problem hiding this comment.
I suggest renaming these, remove "Frozen"
(+ rebase meanwhile :) )
|
Ready! |
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2017
… (ro0NL) This PR was merged into the 4.0-dev branch. Discussion ---------- [DI] Remove deprecated dumping an uncompiled container | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | should be | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> See #20634 Commits ------- c1c525c [DI] Remove deprecated dumping an uncompiled container
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #20634