Try PHP7 mode on HHVM #22765
Closed
Try PHP7 mode on HHVM #22765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
May 18, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | let's see |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
@mofarrell looks like that's not enough, any other idea? Could you give it a try on your side? |
|
Related to facebook/hhvm#7198 |
|
@nicolas-grekas you are correct in identifying facebook/hhvm#7198 as the source of the test failure on travis. Unfortunately, until they fix it (or someone contributes a fix) testing HHVM in php-7 mode with an environment that requires composer is currently impossible. |
|
I should mention that you could use php 7 with composer locally then run unit tests locally with hhvm. (I'm not sure the details or possibility of running hhvm and php side by side) |
|
Decision has been made now, we are dropping HHVM. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.