Skip to content

[DependencyInjection] remove deprecated autowiring_types feature #22773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2017
Merged

[DependencyInjection] remove deprecated autowiring_types feature #22773

merged 1 commit into from
May 22, 2017

Conversation

hhamon
Copy link
Contributor

@hhamon hhamon commented May 19, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? no
Fixed tickets ~
License MIT
Doc PR ~

@hhamon hhamon force-pushed the di-remove-autowiring-types-feature branch 3 times, most recently from aa936fa to 6a6404f Compare May 19, 2017 09:24
@hhamon hhamon changed the title [DependencyInjection] remove autowiring_types feature [DependencyInjection] remove deprecated autowiring_types feature May 19, 2017
@hhamon
Copy link
Contributor Author

hhamon commented May 19, 2017 •
edited
Loading

Forward compatibility needed in FrameworkBundle in version 3.4 (see #22774).

@hhamon hhamon mentioned this pull request May 19, 2017
Merged
@nicolas-grekas nicolas-grekas added this to the 4.0 milestone May 19, 2017
@nicolas-grekas
Copy link
Member

missing CHANGELOG updates in components (please check any your other PRs also if any)

@nicolas-grekas
Copy link
Member

rebase needed

@hhamon hhamon force-pushed the di-remove-autowiring-types-feature branch from 6a6404f to 6a6db91 Compare May 21, 2017 19:19
@hhamon
Copy link
Contributor Author

hhamon commented May 21, 2017

@nicolas-grekas rebased! Still need to update the CHANGELOG file.

nicolas-grekas
nicolas-grekas reviewed May 21, 2017
View reviewed changes
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -370,12 +370,6 @@ private function populateAvailableType($id, Definition $definition)
return;
}

foreach ($definition->getAutowiringTypes(false) as $type) {
$this->definedTypes[$type] = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this property is not used anymore, it should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? It seems the property remains used several times in this class.

Copy link
Member

@nicolas-grekas nicolas-grekas May 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's read, but never written to, so yes, I'm sure :)

@nicolas-grekas
Copy link
Member

grep autowiring.*type src/ -ri raises a few more occurrences

@hhamon hhamon force-pushed the di-remove-autowiring-types-feature branch 2 times, most recently from 6a89a3f to e2c1d12 Compare May 22, 2017 08:19
@hhamon hhamon force-pushed the di-remove-autowiring-types-feature branch from e2c1d12 to 6fdcb84 Compare May 22, 2017 09:28
@hhamon
Copy link
Contributor Author

hhamon commented May 22, 2017

I think it's good to go now.

The remaining files below only deal with the autowire option but not autowiring_types.

src//Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
src//Symfony/Bundle/FrameworkBundle/Tests/Functional/AutowiringTypesTest.php
src//Symfony/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/AutowiringTypes/AutowiredServices.php
src//Symfony/Bundle/FrameworkBundle/Tests/Functional/app/AutowiringTypes/config.yml
src//Symfony/Bundle/SecurityBundle/Tests/Functional/AutowiringTypesTest.php
src//Symfony/Bundle/SecurityBundle/Tests/Functional/app/AutowiringTypes/config.yml

Maybe they should be renamed at some point.

nicolas-grekas
nicolas-grekas approved these changes May 22, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas
Copy link
Member

Thank you @hhamon.

@nicolas-grekas nicolas-grekas merged commit 6fdcb84 into symfony:master May 22, 2017
nicolas-grekas added a commit that referenced this pull request May 22, 2017
@nicolas-grekas
feature #22773 [DependencyInjection] remove deprecated autowiring_typ…
88cddb8 
…es feature (hhamon)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[DependencyInjection] remove deprecated autowiring_types feature

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

6fdcb84 [DependencyInjection] remove deprecated autowiring_types feature
@fabpot fabpot mentioned this pull request Oct 19, 2017
Merged
@King2500 King2500 mentioned this pull request Jul 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
BC Break DependencyInjection Status: Needs Review
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hhamon @nicolas-grekas @carsonbot