-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[4.0][BC Break] Removed BC layers for ControllerResolver::getArguments() #22779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The argument is not meant to become mandatory, but to instantiate an |
@stof you're right. |
Minor addition, @nicolas-grekas has added the service resolver, but this one isn't added to the default set. |
@iltar that's expected, as this ServiceResolver requires some wiring, it is not standalone. So using it requires configuring the resolver externally and passing it to the kernel (which is what FrameworkBundle does for instance) |
@stof fair enough, I see that the dependency is optional as well. I got confused because it's between the other resolvers here: https://github.com/symfony/symfony/tree/master/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver |
fabbot failure looks legit |
@nicolas-grekas indeed, should be fixed now! |
Thank you @iltar. |
Removes the Backwards Compatibility layer for the
ControllerResolver
that depends on theArgumentValueResolver
.There's still 1 bit left in theHttpKernel
, but I don't quite know how this is solved in the best way:The 4th argument is now mandatory, but I can't make it mandatory without switching it with the request stack.I can make both mandatoryI can make it?RequestStack
I can switch the argumentsEach of those area a BC break but for the request stack or the switch, there is no BC layer yet (could be done in 3.4).