Skip to content

[DI][Serializer] Fix missing de(normalizer|coder) autoconfig #22781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2017
Merged

[DI][Serializer] Fix missing de(normalizer|coder) autoconfig #22781

merged 1 commit into from
May 21, 2017

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented May 19, 2017

Q A
Branch? 3.3
Bug fix? yes(ish)
New feature? no (at least complete the 3.3 feature)
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Just migrating an app to 3.3.0-RC1, I get surprised it wasn't already registered :)

@dunglas
Copy link
Member

dunglas commented May 19, 2017

Can you do the same for DecoderInterface?

@ogizanagi
Copy link
Contributor Author

Oh, indeed, good catch! Done.

@ogizanagi ogizanagi changed the title [DI][Serializer] Fix missing denormalizer autoconfig [DI][Serializer] Fix missing de(normalizer|coder) autoconfig May 19, 2017
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (failure unrelated)

@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 3c3a276 into symfony:3.3 May 21, 2017
nicolas-grekas added a commit that referenced this pull request May 21, 2017
…ig (ogizanagi)

This PR was merged into the 3.3 branch.

Discussion
----------

[DI][Serializer] Fix missing de(normalizer|coder) autoconfig

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes(ish)
| New feature?  | no (at least complete the 3.3 feature)
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Just migrating an app to `3.3.0-RC1`, I get surprised it wasn't already registered :)

Commits
-------

3c3a276 [DI][Serializer] Fix missing de(normalizer|coder) autoconfig
@ogizanagi ogizanagi deleted the fix/di/serializer_denormalizer_autoconfig branch May 21, 2017 08:46
@fabpot fabpot mentioned this pull request May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants