[TwigBridge] remove deprecated features #22783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 19, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
66825f2 to
2c1f1ce
Compare
stof
requested changes
May 19, 2017
| private $engine; | ||
|
|
||
| public function __construct(TwigRendererEngineInterface $engine, CsrfTokenManagerInterface $csrfTokenManager = null) | ||
| public function __construct(TwigRendererEngine $engine, CsrfTokenManagerInterface $csrfTokenManager = null) |
There was a problem hiding this comment.
shouldn't the typeint be in FormRendererEngineInterface ?
There was a problem hiding this comment.
Not sure, shouldn't the Twig extension be sure that the underlying renderer engine supports Twig? By the way, if we did that change, that would mean that we could entirely drop the TwigRenderer class and use the parent AbstractRendererEngine class instead.
| private $engine; | ||
|
|
||
| public function __construct(TwigRendererEngineInterface $engine, CsrfTokenManagerInterface $csrfTokenManager = null) | ||
| public function __construct(TwigRendererEngine $engine, CsrfTokenManagerInterface $csrfTokenManager = null) | ||
| { | ||
| parent::__construct($engine, $csrfTokenManager); | ||
|
|
||
| $this->engine = $engine; |
There was a problem hiding this comment.
you don't actually need this property, as it is now unused.
2c1f1ce to
7ebf424
Compare
Tobion
suggested changes
May 20, 2017
| @@ -17,25 +17,10 @@ | |||
| /** | |||
| * @author Bernhard Schussek <bschussek@gmail.com> | |||
| */ | |||
| class TwigRenderer extends FormRenderer implements TwigRendererInterface | |||
| class TwigRenderer extends FormRenderer | |||
There was a problem hiding this comment.
This class has no value anymore. Symfony\Component\Form\FormRenderer can be used directly now. So TwigRenderer should be deprecated and removed IMO.
|
@xabbuh would be great to finish this one, that's one of the two last PR removing deprecated features. Thanks! |
|
@nicolas-grekas I think we should wait for #23437 to be able to remove the |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [TwigBridge] deprecate TwigRenderer | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #22783 (comment) | License | MIT | Doc PR | <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the 3.4, legacy code removals go to the master branch. - Please fill in this template according to the PR you're about to submit. - Replace this comment by a description of what your PR is solving. --> Commits ------- 6ea71cb [TwigBridge] deprecate TwigRenderer
|
#23437 merged now :) |
7ebf424 to
bfebf6a
Compare
|
rebase unlocked :) |
9cd55f5 to
4c3f90c
Compare
4c3f90c to
aae494c
Compare
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 18, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [TwigBridge] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- aae494c [TwigBridge] remove deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.