[DependencyInjection] Fix dumping of RewindableGenerator with empty IteratorArgument #22790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a504ba to
c291b46
Compare
c291b46 to
c2db0c1
Compare
nicolas-grekas
approved these changes
May 20, 2017
dunglas
approved these changes
May 21, 2017
|
Thank you @meyerbaptiste. |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
…ith empty IteratorArgument (meyerbaptiste) This PR was merged into the 3.3 branch. Discussion ---------- [DependencyInjection] Fix dumping of RewindableGenerator with empty IteratorArgument | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22780 | License | MIT | Doc PR | N/A According with #22780 (comment), when an `IteratorArgument` is empty, the closure generated by the `PhpDumper` should be `function () { return new EmptyIterator();` instead of `function () {}`, which is an invalid traversable for the `RewindableGenerator`. Commits ------- c2db0c1 [DependencyInjection] Fix dumping of RewindableGenerator with empty IteratorArgument
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According with #22780 (comment), when an
IteratorArgumentis empty, the closure generated by thePhpDumpershould befunction () { return new EmptyIterator();instead offunction () {}, which is an invalid traversable for theRewindableGenerator.