[Validator] remove deprecated features #22795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 20, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
900b5a9 to
cd5c7aa
Compare
ro0NL
reviewed
May 20, 2017
| @@ -59,7 +59,7 @@ public function validate($value, Constraint $constraint) | |||
| } | |||
|
|
|||
| if (false === $constraint->strict) { | |||
| @trigger_error('Setting the strict option of the Choice constraint to false is deprecated since version 3.2 and will be removed in 4.0.', E_USER_DEPRECATED); | |||
| throw new \RuntimeException('The "strict" option of the Choice constraint should not be used.'); | |||
There was a problem hiding this comment.
You can remove the entire option right? given
... and will be removed in 4.0.
There was a problem hiding this comment.
We cannot completely remove the option as that would break code that was valid in 3.4 (as the base Constraint class would complain about an unknown option while setting the strict option to true is the forward compatible change to be made in 3.x).
There was a problem hiding this comment.
we should remove any use of the "strict" property in the class, isn't it?
cd5c7aa to
ad7a3cb
Compare
|
FC layer missing in 3.4? |
|
|
|
see #22815 |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 3.4 branch. Discussion ---------- do not used deprecated validator test case class | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22795 (comment) | License | MIT | Doc PR | Commits ------- f20885e do not used deprecated validator test case class
ad7a3cb to
46c9101
Compare
|
tests are green, ready to be reviewed |
46c9101 to
bbd656b
Compare
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Validator] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- bbd656b [Validator] remove deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.