[EventDispatcher] remove deprecated features #22796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 20, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
0e66009 to
dbd7e50
Compare
chalasr
requested changes
May 20, 2017
There was a problem hiding this comment.
The following assignment
should be removed with usage below (see #22223)
Koc
reviewed
May 20, 2017
| @@ -7,7 +7,7 @@ | |||
| <services> | |||
| <defaults public="false" /> | |||
|
|
|||
| <service id="event_dispatcher" class="Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher" public="true"> | |||
| <service id="event_dispatcher" class="Symfony\Component\EventDispatcher\EventDispatcher" public="true"> | |||
| <argument type="service" id="service_container" /> | |||
There was a problem hiding this comment.
does this argument not require changes?
0eb15ca to
a7fae50
Compare
|
Looks like 3.4 doesn't like this change - forward layer missing? |
|
see #22814 |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [FrameworkBundle] FC with EventDispatcher 4.0 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22796 (comment) | License | MIT | Doc PR | Commits ------- b7c76f7 [FrameworkBundle] FC with EventDispatcher 4.0
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [FrameworkBundle] FC with EventDispatcher 4.0 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#22796 (comment) | License | MIT | Doc PR | Commits ------- b7c76f7 [FrameworkBundle] FC with EventDispatcher 4.0
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [FrameworkBundle] FC with EventDispatcher 4.0 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22796 (comment) | License | MIT | Doc PR | Commits ------- b7c76f7 [FrameworkBundle] FC with EventDispatcher 4.0
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [FrameworkBundle] FC with EventDispatcher 4.0 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#22796 (comment) | License | MIT | Doc PR | Commits ------- b7c76f7 [FrameworkBundle] FC with EventDispatcher 4.0
a7fae50 to
598bec4
Compare
|
builds are green, ready to be reviewed |
| @@ -309,7 +300,6 @@ public function load(array $configs, ContainerBuilder $container) | |||
| 'Symfony\\Component\\DependencyInjection\\Container', | |||
|
|
|||
| 'Symfony\\Component\\EventDispatcher\\Event', | |||
| 'Symfony\\Component\\EventDispatcher\\ContainerAwareEventDispatcher', | |||
There was a problem hiding this comment.
I think you should revert this line: it will only create a conflict with that other PR removing the block
There was a problem hiding this comment.
without this change it would add to class cache non-existent class. Maybe better merge #22786 first
There was a problem hiding this comment.
ok merged, asis, #22786 already has conflicts to fix
There was a problem hiding this comment.
@Koc Actually, that would not have been an issue. This part of the code is never executed on PHP 7 (which is a requirement for Symfony 4).
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [EventDispatcher] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 598bec4 [EventDispatcher] remove deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.