Skip to content

[Console] Remove deprecated features #22799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2017
Merged

[Console] Remove deprecated features #22799

merged 1 commit into from
May 21, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented May 20, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #18999 #19012
License MIT
Doc PR n/a

@chalasr chalasr force-pushed the 4.0-console-removals branch from a2712c7 to 791a2ac Compare May 20, 2017 10:26
@nicolas-grekas nicolas-grekas modified the milestone: 4.0 May 20, 2017
nicolas-grekas
nicolas-grekas approved these changes May 20, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chalasr chalasr force-pushed the 4.0-console-removals branch 2 times, most recently from e4a6baa to 1a7bcf7 Compare May 21, 2017 10:17
@chalasr
Copy link
Member Author

chalasr commented May 21, 2017

removed [BC BREAK] from changelog entries

@chalasr chalasr force-pushed the 4.0-console-removals branch from 1a7bcf7 to 4cde3b9 Compare May 21, 2017 10:24
@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 4cde3b9 into symfony:master May 21, 2017
nicolas-grekas added a commit that referenced this pull request May 21, 2017
@nicolas-grekas
feature #22799 [Console] Remove deprecated features (chalasr)
79e880c 
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Console] Remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~~#18999 #19012~~
| License       | MIT
| Doc PR        | n/a

Commits
-------

4cde3b9 [Console] Remove deprecated features
@chalasr chalasr deleted the 4.0-console-removals branch May 21, 2017 13:04
@fabpot fabpot mentioned this pull request Oct 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
BC Break Console Status: Needs Review
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @nicolas-grekas @carsonbot