Add missing doc param & deprecation changelog entries #22822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
May 21, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #22749 (comment) |
| License | MIT |
| Doc PR | n/a |
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
…halasr) This PR was merged into the 3.3 branch. Discussion ---------- Add missing doc param & deprecation changelog entries | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22749 (comment) | License | MIT | Doc PR | n/a Commits ------- 7b14d4f Add missing doc param & deprecation changelog entries
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2017
…bbuh) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle][Translation] fix docblock position | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22822 | License | MIT | Doc PR | The `$defaultLocale` argument is present in the `Translator` class of the FrameworkBundle, but is not part of the Translation component. Commits ------- 0829964 fix docblock position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.