Skip to content

[Validator] improve strict option value deprecation #22826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2017
Merged

[Validator] improve strict option value deprecation #22826

merged 1 commit into from
May 21, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 21, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone May 21, 2017
nicolas-grekas
nicolas-grekas approved these changes May 21, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit a820b42 into symfony:3.4 May 21, 2017
nicolas-grekas added a commit that referenced this pull request May 21, 2017
@nicolas-grekas
feature #22826 [Validator] improve strict option value deprecation (x…
c3be3ea 
…abbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] improve strict option value deprecation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

a820b42 improve strict option value deprecation
@xabbuh xabbuh deleted the strict-option-deprecation-trigger branch May 21, 2017 13:01
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Deprecation Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@xabbuh @nicolas-grekas