[HttpFoundation] remove deprecated features #22863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 22, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
looks like we need #22873 first |
4a4593f to
6651573
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2017
… (xabbuh) This PR was merged into the 3.3 branch. Discussion ---------- [HttpKernel] don't call getTrustedHeaderName() if possible | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/235008102 (failing tests of #22863) | License | MIT | Doc PR | Commits ------- 6350dab don't call getTrustedHeaderName() if possible
6651573 to
96d031b
Compare
|
so, InlineFragmentRenderer 4 still conditionally calls getTrustedHeaderName for BC for 3.4? |
| * the `Request::setTrustedHeaderName()` and `Request::getTrustedHeaderName()` | ||
| methods have been removed | ||
| * the `Request::HEADER_CLIENT_IP` constant has been removed, use | ||
| `Request::HEADER_X_FORWARDED_FOR` instead |
There was a problem hiding this comment.
you should configure your line breaks at 120, this is cutting too early to me
There was a problem hiding this comment.
IIRC @fabpot once talked about a limit of 80 characters in changelog files
96d031b to
b13346b
Compare
Ah no, that was not intended. Should be fixed. |
|
Status: Needs Review |
Merged
b13346b to
17c7a2d
Compare
fabpot
added a commit
that referenced
this pull request
Jun 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [DI] Uncomment code | Q | A | ------------- | --- | Branch? | master <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A I was about fixing all [other occurrences of commented code and `func_get/num_arg(s)`](https://github.com/symfony/symfony/search?utf8=%E2%9C%93&q=func_num_args&type=) as BC layer usages at once, but the following PRs will already cover it: - HttpFoundation: #22863 - Serializer: #23241 - Process: #22836 - DotEnv: #23242 So it only remains DI ones. Commits ------- 03f33b5 [DI] Uncomment code
fabpot
approved these changes
Jun 21, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [HttpFoundation] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 17c7a2d [HttpFoundation] remove deprecated features
|
The documentation for getClientIp(), getPort(), isSecure() and getHost() includes the following paragraph:
This feature is no longer supported, so this must be removed from the documentation. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2017
…tion (xabbuh) This PR was merged into the 4.0-dev branch. Discussion ---------- [HttpFoundation] remove no longer valid docblock description | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22863 (comment) | License | MIT | Doc PR | Commits ------- 1beee41 remove no longer valid docblock description
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.