Skip to content

[Routing] remove deprecated features #22880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 23, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

* dropped support for using UTF-8 route patterns without using the `utf8`
option
* dropped support for using UTF-8 route requirements without using the `utf8`
option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line break looks useless

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with minor comment

@xabbuh xabbuh force-pushed the routing-remove-deprecated-features branch from a431035 to 9560031 Compare May 24, 2017 08:45
@fabpot
Copy link
Member

fabpot commented May 25, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 9560031 into symfony:master May 25, 2017
fabpot added a commit that referenced this pull request May 25, 2017
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Routing] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

9560031 [Routing] remove deprecated features
@xabbuh xabbuh deleted the routing-remove-deprecated-features branch May 26, 2017 06:29
@fabpot fabpot mentioned this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants