[FrameworkBundle][Validator] Move the PSR-11 factory to the component #22905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(but missing composer.json update to make deps=low/high tests pass) |
|
good for merge on my side |
|
OK, deps=high failing is because this is not yet merged in 3.4 |
stof
approved these changes
May 26, 2017
|
Thank you @ogizanagi. |
stof
added a commit
that referenced
this pull request
May 26, 2017
…o the component (ogizanagi) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle][Validator] Move the PSR-11 factory to the component | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #22887 (comment) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Instead of the 3 following deprecations: * The `ConstraintValidatorFactory::$validators` and `$container` properties have been deprecated and will be removed in 4.0. * Extending `ConstraintValidatorFactory` is deprecated and won't be supported in 4.0. * Passing an array of validators or validator aliases as the second argument of `ConstraintValidatorFactory::__construct()` is deprecated since 3.3 and will be removed in 4.0. Use the service locator instead. I'd suggest simply deprecating the FrameworkBundle's class in favor of using a new `ContainerConstraintValidatorFactory`. To me, there is no reason anyone using the validator component without the framework bundle cannot use this PSR-11 compliant implementation, nor I see a reason to make it final. Commits ------- 68c1917 [FrameworkBundle][Validator] Move the PSR-11 factory to the component
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the 3 following deprecations:
ConstraintValidatorFactory::$validatorsand$containerpropertieshave been deprecated and will be removed in 4.0.
ConstraintValidatorFactoryis deprecated and won't be supported in 4.0.ConstraintValidatorFactory::__construct()is deprecated since 3.3 and willbe removed in 4.0. Use the service locator instead.
I'd suggest simply deprecating the FrameworkBundle's class in favor of using a new
ContainerConstraintValidatorFactory. To me, there is no reason anyone using the validator component without the framework bundle cannot use this PSR-11 compliant implementation, nor I see a reason to make it final.