[FrameworkBundle] Only override getProjectDir if it exists in the kernel #22921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9634007 to
c7ed08e
Compare
|
sorry about that, I have rebased to 3.3 |
stof
approved these changes
May 26, 2017
|
Thank you @aschempp. |
fabpot
added a commit
that referenced
this pull request
May 26, 2017
… in the kernel (aschempp) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] Only override getProjectDir if it exists in the kernel | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22872, #2289 | License | MIT | Doc PR | - As discussed with @nicolas-grekas, the `getProjectDir` method does not belong to `KernelInterface` so it can't just be called. I think we should also not add the method to the kernel if it does not exist in the parent, because we would not have a useful value to return. Commits ------- c7ed08e Only override getProjectDir if it exists in the kernel
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @nicolas-grekas, the
getProjectDirmethod does not belong toKernelInterfaceso it can't just be called. I think we should also not add the method to the kernel if it does not exist in the parent, because we would not have a useful value to return.