[Config] Fallback to regular import when glob fails #22940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
May 29, 2017
ro0NL
reviewed
May 29, 2017
| } else { | ||
| foreach ($this->glob($resource, false, $_, $ignoreErrors) as $path => $info) { | ||
| ++$ct; | ||
| if (is_string($resource) && false !== strpbrk($resource, '*?{[')) { |
There was a problem hiding this comment.
(...) || $type === 'glob' right?
There was a problem hiding this comment.
not sure it would change anything, so not to me
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 29, 2017
…as-grekas) This PR was merged into the 4.0-dev branch. Discussion ---------- [Config] Fallback to regular import when glob fails | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22938 | License | MIT | Doc PR | - Fixes a BC break as reported in linked issue. Commits ------- 29802a2 [Config] Fallback to regular import when glob fails
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 29, 2017
…as-grekas) This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #22940). Discussion ---------- [Config] Fallback to regular import when glob fails | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22938 | License | MIT | Doc PR | - Fixes a BC break as reported in linked issue. Commits ------- 7b4066e [Config] Fallback to regular import when glob fails
Merged
|
This has broken my app while upgrading from 3.3.0-RC1 to 3.3.0. 😞 Kernel::configureRoutes() +- same as in the Flex recipe, |
|
Please open an issue with a description of the conditions + reproducer if possible |
|
Here you go: #22950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a BC break as reported in linked issue.