[Cache] Ignore missing annotations.php #22965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In 3.2 we use file_exists, this somehow got lost in a merge I guess |
|
you refactored in #20694 :) from the looks of it i'd say stream_resolve_include_path + include without @ but im not sure that needs to be supported or so; otherwise file_exists/is_file will do. Note 3.2 doesnt use @ |
|
let's do the same as in 3.2, that's fine |
|
This should do. |
fabpot
approved these changes
May 31, 2017
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
May 31, 2017
This PR was squashed before being merged into the 3.3 branch (closes #22965). Discussion ---------- [Cache] Ignore missing annotations.php | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes (different in 3.2) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Avoids the following notices if cache is not warmed up (i.e. `cache:clear --no-warmup` > hit the browser). ``` Warning: include(<base-path>/app/cache/<env>/annotations.php): failed to open stream: No such file or directory Warning: include(): Failed opening '<base-path>/app/cache/<env>/annotations.php' for inclusion (include_path='.:/usr/share/pear:/usr/share/php') ``` Commits ------- e8f70c7 [Cache] Ignore missing annotations.php
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the following notices if cache is not warmed up (i.e.
cache:clear --no-warmup> hit the browser).