[Di] Remove closure-proxy arguments #23022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89636d7 to
42ac3eb
Compare
42ac3eb to
57daadb
Compare
fabpot
approved these changes
Jun 1, 2017
|
and green :) |
chalasr
approved these changes
Jun 1, 2017
|
👍 |
stof
approved these changes
Jun 2, 2017
nicolas-grekas
added a commit
that referenced
this pull request
Jun 2, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Di] Remove closure-proxy arguments | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - With #23008, we don't need this in core anymore. Let's drop it now. Technically that's a BC break, but for a feature that is very new, and still quite hidden. Doing this now would save us from maintaining this code, and help reduce the overall complexity. Basically reverts #20953 Commits ------- 57daadb [Di] Remove closure-proxy arguments
Merged
fabpot
added a commit
that referenced
this pull request
Oct 6, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [DependencyInjection] remove unused fixtures file | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I was wondering why the conflict markers in the `master` branch (see https://github.com/symfony/symfony/blob/b6e9471ded49e698c8c2468be9c1b42c621efeac/src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services31.php#L43-L52) did not cause any issues. Turned out that this fixtures file was not used anymore (it was only partially removed in #23022). Commits ------- 3702e5f remove unused fixtures file
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #23008, we don't need this in core anymore.
Let's drop it now.
Technically that's a BC break, but for a feature that is very new, and still quite hidden.
Doing this now would save us from maintaining this code, and help reduce the overall complexity.
Basically reverts #20953